Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.29 first Crater run #53072

Closed
pietroalbini opened this issue Aug 4, 2018 · 21 comments
Closed

1.29 first Crater run #53072

pietroalbini opened this issue Aug 4, 2018 · 21 comments
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Comments

@pietroalbini
Copy link
Member

cc @rust-lang/release
@pietroalbini pietroalbini added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Aug 4, 2018
@pietroalbini
Copy link
Member Author

@craterbot run name=beta-1.29-1 start=1.28.0 end=beta-2018-08-01 cap-lints=warn p=1

@craterbot
Copy link
Collaborator

👌 Experiment beta-1.29-1 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Aug 4, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment beta-1.29-1 is now running on agent crater-1.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@petrochenkov
Copy link
Contributor

petrochenkov commented Aug 5, 2018 •
edited
Loading

@pietroalbini
Does this crater run include #52841?

@Mark-Simulacrum
Copy link
Member

No, I've nominated that PR for beta backport as I presume you want that -- we cut beta ~Tuesday whereas that PR landed ~Friday I believe.

@petrochenkov
Copy link
Contributor

@Mark-Simulacrum
Not backport, that PR is known to cause some breakage and we need to know what it broke.

@Mark-Simulacrum
Copy link
Member

Ah, okay. We can probably start a crater run separately for it, let me see if I can do that (on a different issue). Will cc you.

@petrochenkov petrochenkov mentioned this issue Aug 5, 2018
Merged
@Mark-Simulacrum
Copy link
Member

@craterbot name=pr-52841 start=master#40cb4478a3f550bf12d81cdcf08cc9ef3985ed41 end=master#40e4b6ee3dd70a05007915bd1c15c150a7b7899f cap-lints=warn mode=check-only

@craterbot
Copy link
Collaborator

🚨 Error: the experiment pr-52841 can't be edited anymore.

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot abort=pr-52841

@craterbot
Copy link
Collaborator

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ping @rust-lang/infra!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

@craterbot abort name=pr-52841

@craterbot
Copy link
Collaborator

🗑️ Experiment pr-52841 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 6, 2018
@Mark-Simulacrum
Copy link
Member

@craterbot run name=pr-52841 start=master#40cb4478a3f550bf12d81cdcf08cc9ef3985ed41 end=master#40e4b6ee3dd70a05007915bd1c15c150a7b7899f cap-lints=warn mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-52841 created and queued.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2018
@craterbot
Copy link
Collaborator

🚧 Experiment pr-52841 is now running on agent crater-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@Mark-Simulacrum
Copy link
Member

Er, wrong issue for all those commands. Shouldn't matter much though.

@craterbot
Copy link
Collaborator

🎉 Experiment beta-1.29-1 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 7, 2018
@scottmcm
Copy link
Member

scottmcm commented Aug 8, 2018

Awesome to see the unstable_name_collisions warning in the before for a bunch of these breaks :)

@Mark-Simulacrum
Copy link
Member

Triaged the report, no new regressions -- mostly flatten and #53140.

@craterbot
Copy link
Collaborator

🎉 Experiment pr-52841 is completed!
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@pietroalbini @Mark-Simulacrum @petrochenkov @scottmcm @craterbot