Skip to content

Rename Android target triple #5330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Mar 12, 2013 · 5 comments
Closed

Rename Android target triple #5330

brson opened this issue Mar 12, 2013 · 5 comments
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-android Operating system: Android
Milestone
0.6

Comments

@brson
Copy link
Contributor

brson commented Mar 12, 2013

Currently rustc uses arm-unknown-android but this doesn't seem to be the preferred triple. I think @sanxiyn mentioned a better one but I can't find it. Maybe arm-linux-androidabi.
@alexrp
Copy link

alexrp commented Mar 12, 2013

arm-linux-androideabi is the triple used by the Android NDK.

@yichoi
Copy link
Contributor

yichoi commented Mar 12, 2013

You read my mind. I will do that at once

@yichoi
Copy link
Contributor

yichoi commented Mar 13, 2013

I renamed arm-unknown-android to arm-linux-androideabi, however more delicate function of get_os and get_arch in driver.rs needed since str::contains cause error by order. I will update patch soon

@yichoi yichoi mentioned this issue Mar 13, 2013
Merged
@yichoi
Copy link
Contributor

yichoi commented Mar 13, 2013

I will update doc after patch landed

@yichoi
Copy link
Contributor

yichoi commented Mar 20, 2013

I've updated doc
It reflects renaming arm-unknon-linux to arm-linux-androideabi

bors added a commit to rust-lang-ci/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5330 - matthiaskrgr:newlint_expl, r=flip1995
89cffe1 
new_lint.rs: encourage authors to write more detailed code samples in lint descriptions (linted as well as fixed code)

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. O-android Operating system: Android
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
3 participants
@alexrp @brson @yichoi