Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate remaining compile-fail tests to ui #53353

Closed
davidtwco opened this issue Aug 14, 2018 · 2 comments
Closed

Migrate remaining compile-fail tests to ui #53353

davidtwco opened this issue Aug 14, 2018 · 2 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@davidtwco
Copy link
Member

As part of #53196, compile-fail tests were migrated to ui tests. As part of this PR, some tests remained as compile-fail tests - due to an unresolvable issue (at the time) with the test that meant delaying migration meant more sense than holding up the PR (which needed rebased a lot). The main issues exhibited were:

  • Extra lines of output on some platforms - there is currently no way to normalize a whole line out of the output, therefore tests that had extra lines on some platforms had to say as compile-fail tests.
  • Non-deterministic ordering of error messages.
@davidtwco davidtwco mentioned this issue Aug 14, 2018
Closed
@estebank estebank added the A-testsuite Area: The testsuite used to check the correctness of rustc label Aug 14, 2018
@petrochenkov petrochenkov mentioned this issue Oct 20, 2018
Merged
bors added a commit that referenced this issue Oct 21, 2018
@bors
Auto merge of #55236 - petrochenkov:pfail, r=davidtwco
12a88a6 
Move parse-fail tests to UI

cc #53353

r? @davidtwco
@petrochenkov petrochenkov mentioned this issue Dec 2, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this issue Dec 4, 2018
@kennytm
Rollup merge of rust-lang#56444 - petrochenkov:uifull, r=davidtwco
2d7e7cf 
Move compile-fail-fulldeps tests to UI

cc rust-lang#53353

r? @davidtwco
bors added a commit that referenced this issue Dec 9, 2018
@bors
Auto merge of #56444 - petrochenkov:uifull, r=davidtwco
b755501 
Move compile-fail-fulldeps tests to UI

cc #53353

r? @davidtwco
@estebank estebank mentioned this issue Jan 15, 2019
Closed
@davidtwco davidtwco mentioned this issue Jun 25, 2019
Closed
@Centril Centril added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Jun 25, 2019
@estebank
Copy link
Contributor

estebank commented Oct 18, 2019 •
edited
Loading

CC #65440

@estebank estebank reopened this Oct 18, 2019
@wesleywiser
Copy link
Member

This was completed in #80453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@wesleywiser @Centril @davidtwco @estebank