-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
html5ever failing to compile on perf #53495
Comments
Unfortunately, this restriction is necessary for #52234 to work soundly without causing much worse issues like #53053 (comment). |
This is an expected "can't make an omelette" regression from enabling macro modularization, more or less. |
Hmm, I think we can report this error as a deprecation lint for some time though. |
Leaving this open to track the compat lint fix. |
Hm, so the atom macro and the atom module are public API for the string-cache crate so it's unclear to me that we can easily fix this in source unless I'm missing something -- @petrochenkov, do you have any guidance on the best way to apply a fix? |
Turned into a deprecation lint in #53653 |
html5ever is failing to compile in perf with this error; I'm not sure if this is something we need to fix in source or if it's a regression.
cc @petrochenkov
The text was updated successfully, but these errors were encountered: