Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global paths cannot start with crate #53770

Closed
cramertj opened this issue Aug 28, 2018 · 2 comments
Closed

Global paths cannot start with crate #53770

cramertj opened this issue Aug 28, 2018 · 2 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@cramertj
Copy link
Member

There was a recent regression in the ability to write code like

use {
    crate::{...},
    ...
};

It used to work under the new edition but now reports "failed to resolve. global paths cannot start with crate". cc @eddyb, @petrochenkov
@cramertj
Copy link
Member Author

Additionally, use { self::... }; and use { super::... }; have never worked, and it'd be great if these could be fixed as well (though obviously that's a separate issue from the specific regression here).

@eddyb
Copy link
Member

eddyb commented Aug 28, 2018

One more radical solution (than the immediate "defer insertion of CrateRoot until you have the first path segment) is to never insert CrateRoot on any edition, and instead treat ModuleOrUniformRoot::UniformRoot like the result of resolve_crate_root, in resolve_ident_in_module_unadjusted, when uniform_paths is not enabled.

@cramertj cramertj added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 30, 2018
@eddyb eddyb mentioned this issue Sep 6, 2018
Merged
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Sep 8, 2018
@Mark-Simulacrum
Rollup merge of rust-lang#53988 - eddyb:issue-53770, r=petrochenkov
9a442e7 
rustc_resolve: only prepend CrateRoot to a non-keyword segment.

Fixes rust-lang#53770 by treating `use` paths as absolute in a finer-grained manner, specifically:
```rust
use {a, crate::b, self::c, super::d};
```
Used to be interpreted as if it were (when `uniform_paths` is not enabled):
```rust
use ::{a, crate::b, self::c, super::d};
```
With this PR, the `CrateRoot` pseudo-keyword indicating an absolute path is only inserted when the first path segment is found (if it's not a keyword), i.e. the example behaves like:
```rust
use {::a, crate::b, self::c, super::d};
```
This should (finally) make `use {path};` fully equivalent to `use path;`.

r? @petrochenkov cc @cramertj @joshtriplett @nikomatsakis
bors added a commit that referenced this issue Sep 9, 2018
@bors
Auto merge of #53988 - eddyb:issue-53770, r=petrochenkov
3d2fc45 
rustc_resolve: only prepend CrateRoot to a non-keyword segment.

Fixes #53770 by treating `use` paths as absolute in a finer-grained manner, specifically:
```rust
use {a, crate::b, self::c, super::d};
```
Used to be interpreted as if it were (when `uniform_paths` is not enabled):
```rust
use ::{a, crate::b, self::c, super::d};
```
With this PR, the `CrateRoot` pseudo-keyword indicating an absolute path is only inserted when the first path segment is found (if it's not a keyword), i.e. the example behaves like:
```rust
use {::a, crate::b, self::c, super::d};
```
This should (finally) make `use {path};` fully equivalent to `use path;`.

r? @petrochenkov cc @cramertj @joshtriplett @nikomatsakis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eddyb @cramertj