Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cargo fix for rename deprecations #53802

Closed
withoutboats opened this issue Aug 29, 2018 · 1 comment · Fixed by #59372
Closed

Support cargo fix for rename deprecations #53802

withoutboats opened this issue Aug 29, 2018 · 1 comment · Fixed by #59372
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-feature-request Category: A feature request, i.e: not implemented / a PR.

Comments

@withoutboats
Copy link
Contributor

Ideally, when a deprecation happens because of a rename, cargo fix could rename it for you.

We could make the deprecation warning issue the correct suggestion by adding another field to the rustc_deprecated attribute, as in:

#[rustc_deprecated(renamed = "std::str::str::trim_start")]
@withoutboats withoutboats mentioned this issue Aug 29, 2018
Merged
@kennytm kennytm added A-diagnostics Area: Messages for errors, warnings, and lints C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Aug 30, 2018
@kornelski
Copy link
Contributor

kornelski commented Sep 14, 2018 •
edited
Loading

That would be great. I've used these methods in many places.

While I like the new names better, I don't feel the need to change my code, so the deprecation churn is slightly annoying.

@euclio euclio mentioned this issue Mar 22, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Mar 26, 2019
@Centril
Rollup merge of rust-lang#59372 - euclio:rename-trim, r=rkruppe
cb15da7 
add rustfix-able suggestions to trim_{left,right} deprecations

Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
Centril added a commit to Centril/rust that referenced this issue Mar 27, 2019
@Centril
Rollup merge of rust-lang#59372 - euclio:rename-trim, r=rkruppe
8d5bb65 
add rustfix-able suggestions to trim_{left,right} deprecations

Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
Centril added a commit to Centril/rust that referenced this issue Mar 27, 2019
@Centril
Rollup merge of rust-lang#59372 - euclio:rename-trim, r=rkruppe
58bda0c 
add rustfix-able suggestions to trim_{left,right} deprecations

Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
Centril added a commit to Centril/rust that referenced this issue Mar 27, 2019
@Centril
Rollup merge of rust-lang#59372 - euclio:rename-trim, r=rkruppe
9b259c6 
add rustfix-able suggestions to trim_{left,right} deprecations

Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
cuviper added a commit to cuviper/rust that referenced this issue Mar 28, 2019
@cuviper
Rollup merge of rust-lang#59372 - euclio:rename-trim, r=rkruppe
a4bf855 
add rustfix-able suggestions to trim_{left,right} deprecations

Fixes rust-lang#53802 (technically already fixed by rust-lang#58002, but that issue is about these methods).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-feature-request Category: A feature request, i.e: not implemented / a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add rustfix-able suggestions to trim_{left,right} deprecations euclio/rust
3 participants
@kornelski @kennytm @withoutboats