Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argv argument on rust_start lang item etc. has incorrect type #5405

Closed
brson opened this issue Mar 15, 2013 · 1 comment
Closed

argv argument on rust_start lang item etc. has incorrect type #5405

brson opened this issue Mar 15, 2013 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Mar 15, 2013

It says argv is *c_char but it should be **c_char.

bors added a commit that referenced this issue Mar 31, 2013
#5405

Also, renames the confusingly named `use_new_rt` in `libcore/unstable/lang.rs`
@luqmana luqmana closed this as completed Apr 19, 2013
@brson
Copy link
Contributor Author

brson commented Apr 20, 2013

Thanks, luqmana.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Apr 15, 2020
Changes:
````
Rename dummy_hir_id -> parent_hir_id
rustup rust-lang#71116
Change default many single char names threshold
Better precedence case management + more tests
Use only check_expr with parent expr and precedence
Check for Deref trait impl + add fixed version
Report using stmts and expr + tests
Global rework + fix imports
Working basic dereference clip
Add test for zero single char names
Make the single char threshold strict inequality
large_enum_variant: Report sizes of variants
Refactor: Use rustc's `match_def_path`
deps: bump compiletest-rs from 0.4 to 0.5
rustup rust-lang#70643
Explain panic on `E0463` in integration tests
Temporarily disable rustfmt integration test
result_map_unit_fn: Fix incorrect UI tests
Cleanup: Use rustc's is_proc_macro_attr
Cleanup: Use our `sym!` macro more
Fixes rust-lang#5405: redundant clone false positive with arrays
Disallow bit-shifting in `integer_arithmetic` lint
update lints
cargo dev fmt
Make use of Option/Result diagnostic items
Make use of some existing diagnostic items
Say that diagnostic items are preferred over paths
verbose_bit_mask: fix bit mask used in docs
Update documentation for new_ret_no_self
Update doc generation script
Add lint on large const arrays
Make the epsilon note spanless
Split check_fn function
Indicate when arrays are compared in error message
Make epsilon note spanless when comparing arrays
Add float cmp const tests for arrays
Add float cmp tests for arrays
Handle constant arrays with single value
Don't show comparison suggestion for arrays
Allow for const arrays of zeros
Handle evaluating constant index expression
Add handling of float arrays to miri_to_const
Update stderr of float_cmp test
Update field names in is_float
Add tests for float in array comparison
Add lint when comparing floats in an array
````

Fixes rust-lang#71114
bors added a commit to rust-lang-ci/rust that referenced this issue Apr 15, 2020
submodules: update clippy from af5940b to d236b30

Changes:
````
rustup rust-lang#70643
Explain panic on `E0463` in integration tests
Temporarily disable rustfmt integration test
Cleanup: Use rustc's is_proc_macro_attr
Cleanup: Use our `sym!` macro more
Fixes rust-lang#5405: redundant clone false positive with arrays
update lints
verbose_bit_mask: fix bit mask used in docs
Update documentation for new_ret_no_self
````

Fixes rust-lang#71114
oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
Check whether slice elements implement Copy before suggesting to drop
the clone method
oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
Fixes rust-lang#5405: redundant clone false positive with arrays

Check whether slice elements implement Copy before suggesting to drop
the clone method

changelog: add a check for slice indexing on redundant_clone lint
calebcartwright added a commit to calebcartwright/rust that referenced this issue Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

2 participants