Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impls of priv traits should be hidden in the docs #5416

Closed
thestinger opened this issue Mar 17, 2013 · 7 comments
Closed

impls of priv traits should be hidden in the docs #5416

thestinger opened this issue Mar 17, 2013 · 7 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@thestinger
Copy link
Contributor

No description provided.

@catamorphism
Copy link
Contributor

Nominating for milestone 5, production-ready

@brson
Copy link
Contributor

brson commented May 23, 2013

Can't be done without running resolve.

@graydon
Copy link
Contributor

graydon commented May 23, 2013

should be optional at most, as sometimes you want to see them

@graydon
Copy link
Contributor

graydon commented May 23, 2013

just a bug, removing milestone/nomination.

@graydon
Copy link
Contributor

graydon commented Jul 31, 2013

Still relevant though parenting to #8125 metabug on rustdoc_ng

@emberian
Copy link
Member

/cc @Seldaek

This would involve looking at the visibility of the associated trait and excluding the impl from the list if it's not public.

@Seldaek
Copy link
Contributor

Seldaek commented Aug 25, 2013

Didn't find a trait to test it with but it should be done now.

calebcartwright pushed a commit to calebcartwright/rust that referenced this issue Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants