-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
For example:
let device = &self.ctx.device;
let _device = &self.ctx.device;
I don't like that refactor because I might end up with local variables that do nothing. I think cargo fix
should just ignore unused local variables all together. If cargo fix
just renames local variables to hide the warnings from the compiler, then the compiler lint is a bit pointless.
Renaming unused function parameters seems fine.
runiq, pyfisch, TJYSunset, KarelPeeters, Jokler and 2 more
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsC-enhancementCategory: An issue proposing an enhancement or a PR with one.Category: An issue proposing an enhancement or a PR with one.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.