Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggesting for traits do not search the "prelude crates" #54618

Open
nikomatsakis opened this issue Sep 27, 2018 · 1 comment
Open

suggesting for traits do not search the "prelude crates" #54618

nikomatsakis opened this issue Sep 27, 2018 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-edition-2018-lints Area: Lints supporting the 2018 edition C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

As shown in this test case, if you have a crate in the prelude, but you have not imports its trait, and you try to use its methods, you don't get any nice suggestions. This is a shame!

cc @davidtwco
@nikomatsakis nikomatsakis added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-edition-2018-lints Area: Lints supporting the 2018 edition labels Sep 27, 2018
@nikomatsakis nikomatsakis mentioned this issue Sep 27, 2018
Merged
@davidtwco davidtwco self-assigned this Oct 4, 2018
@davidtwco
Copy link
Member

This is currently blocked on working out the approach we want to take to solve the issue. There is a topic on Zulip discussing this.

@davidtwco davidtwco added the I-needs-decision Issue: In need of a decision. label Oct 17, 2018
@davidtwco davidtwco mentioned this issue Nov 2, 2018
Closed
@davidtwco davidtwco removed the I-needs-decision Issue: In need of a decision. label Jan 16, 2019
@davidtwco davidtwco removed their assignment Mar 12, 2019
@crlf0710 crlf0710 added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-edition-2018-lints Area: Lints supporting the 2018 edition C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikomatsakis @crlf0710 @davidtwco