Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebuild LLVM when it changed #54959

Closed
Ekleog opened this issue Oct 10, 2018 · 2 comments · Fixed by #59303
Closed

Rebuild LLVM when it changed #54959

Ekleog opened this issue Oct 10, 2018 · 2 comments · Fixed by #59303
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Ekleog
Copy link

Ekleog commented Oct 10, 2018

I've spent the past few hours looking through documentation for how to build rustc with a patched LLVM without success. Currently, the best I'm at is:

submodules = false
fast-submodules = false

And then build with:

./x.py build --stage 1 src/llvm src/libstd

But even that doesn't rebuild anything unless I rm -Rf build. Which completely loses incremental compilation results.

Is there any way to make this development workflow better? Rebuilding from scratch at every change is… painful.
@kennytm
Copy link
Member

kennytm commented Oct 10, 2018 •
edited
Loading

You need to modify src/rustllvm/llvm-rebuild-trigger to rebuild LLVM.

(tagging this issue as a documentation problem.)

@kennytm kennytm added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Oct 10, 2018
@Ekleog
Copy link
Author

Ekleog commented Oct 10, 2018

Thanks! Leaving open for the documentation problem :)

@steveklabnik steveklabnik added the P-medium Medium priority label Dec 27, 2018
@euclio euclio mentioned this issue Mar 19, 2019
Merged
bors added a commit that referenced this issue Mar 29, 2019
@bors
Auto merge of #59303 - euclio:remove-rebuild-trigger, r=cuviper
2002b4b 
replace llvm-rebuild-trigger with submodule commit hash

As mentioned in #59285.

This PR removes the need to update the `llvm-rebuild-trigger` file. Instead, the latest commit hash of the appropriate LLVM submodule will be stored in the stamp file and used to detect if a build is required.

Fixes #42405.
Fixes #54959.
Fixes #55537.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace llvm-rebuild-trigger with submodule commit hash euclio/rust
3 participants
@steveklabnik @kennytm @Ekleog