rust 2018: local_inner_macros and stringify

[richard-uk1]

I am trying to update yew to work with the 2018 edition. I need to use the local_inner_macros feature, but it seems to clobber built-in macros like stringify and compile_error. Is is possible to just spot these particular macros and not add $crate:: to them?

[petrochenkov]

Is is possible to just spot these particular macros and not add $crate:: to them?

Not without effort that would be disproportionally high for a transitional/deprecated-on-arrival feature like local_inner_macros.
(Built-in macros can be shadowed, so we can't detect them correctly just looking at their name in isolation, we'd basically need some insta-stable form of def-site hygiene.)

If you don't need compatibility with pre-1.30 versions of Rust, $crate is recommended for use instead of local_inner_macros.
If you need compatibility, then built-in macros can be used with local_inner_macros through one more level of indirection.

[Centril]

I'm inclined to agree with @petrochenkov here.

[richard-uk1]

I see, so you can just create a macro that delegates. Hopefully this issue will serve as documentation if anyone else has this issue.

…

On Mon, 22 Oct 2018, 17:28 Mazdak Farrokhzad, ***@***.***> wrote: I'm inclined to agree with @petrochenkov <https://github.com/petrochenkov> here. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#55268 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABU-XiV5tZxM7olvVCnIOg-mYeM50DfUks5unfIhgaJpZM4Xzp33> .

[richard-uk1]

Made a doc PR for this: rust-lang/edition-guide#117

[petrochenkov]

The doc PR has landed, so I'm closing this.