"#[test] attribute is only allowed on fn items" on fn struct method

[matthiaskrgr]

#![feature(test)]
extern crate test;

struct A {}

impl A {
	#[test]
	fn new() -> A {
		A {}
	}
}

#[test]
fn test() {
	let _ = A::new();
}

fn main() {}

warns however the #[test] in fact on a fn item

error: #[test] attribute is only allowed on fn items
  --> src/main.rs:8:2
   |
8  |       fn new() -> A {
   |  _____^
9  | |         A {}
10 | |     }
   | |_____^

Maybe this could be made a bit more clear?

rustc 1.32.0-nightly (25a42b2ce 2018-11-07)

[estebank]

Rewording to something along the lines of "only allowed on bare fn items" (or another, more appropriate way to refer to functions) should be enough.

[zeegomo]

I would like to help with that but I'm a first timer

[smokytheangel0]

the string in question is on line 56 of rust/src/libsyntax_ext/test.rs. I would suggest changing it to '#[test] is only allowed on non-impl fn items". I have no idea what steps are involved in contributing this.

[zeegomo]

I think '#[test] is only allowed on non associated functions' should be good, fn items inside impl are called associated functions or methods (if they have and instance of the struct to work with, i.e &self or &mut self)

[TheSirC]

Should this be closed @estebank ?