rustdoc: "Implementations on Foreign Types" sidebar items should link to specific impls #56018
Labels
A-rustdoc-ui
Area: Rustdoc UI (generated HTML)
C-bug
Category: This is a bug.
S-needs-repro
Status: This issue has no reproduction and needs a reproduction to make progress.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
Comments
jonas-schievink
added
the
T-rustdoc
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 27, 2019
Make "Implementations on Foreign Types" items in sidebar link to specific impls This solves rust-lang#56018 for most cases (though not work for foreign impls with same names)
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 27, 2019
Make "Implementations on Foreign Types" items in sidebar link to specific impls This solves rust-lang#56018 for most cases (though not work for foreign impls with same names)
fmease
added
C-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Each of the impl sections in the "Implementations on Foreign Types" section has its own ID. Consider the foreign impls for the
Streamtrait fromtokio. The first impl header is#impl-Stream, the second impl header is#impl-Stream-1, the third impl header is#impl-Stream-2, and so on.But, the links in the sidebar do not jump to these specific IDs. Instead, they all link to
#impl-Stream, or the first impl in the list. For a trait likeStream, which has many methods and many foreign implementors, this makes it difficult to get to a specific impl (to see the associated types, for example). You have to search the page, collapse the sections, or just scroll.Since unique IDs are already generated for the impl sections, it would be great if the sidebar items used them to make navigation easier.
The text was updated successfully, but these errors were encountered: