Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic="xxx" error message is wrong #56088

Closed
rodrigorc opened this issue Nov 19, 2018 · 1 comment
Closed

panic="xxx" error message is wrong #56088

rodrigorc opened this issue Nov 19, 2018 · 1 comment

Comments

@rodrigorc
Copy link

Problem
The error message when writing an invalid profile.panic option is wrong. It says:

error: incorrect value `xxx` for codegen option `panic` - either `panic` or `abort` was expected

It should say instead:

error: incorrect value `xxx` for codegen option `panic` - either `unwind` or `abort` was expected

That is, valid values for this option are 'unwind' and 'abort', but not 'panic'.

Steps

  1. Add to Cargo.toml: [profile] panic = 'xxx'
  2. Run cargo build.

Output of cargo version:

cargo 1.32.0-nightly (b3d0b2e54 2018-11-15)
@ehuss
Copy link
Contributor

ehuss commented Nov 19, 2018

This is an issue in rustc. I can post a quick fix.

@Mark-Simulacrum Mark-Simulacrum transferred this issue from rust-lang/cargo Nov 20, 2018
@GuillaumeGomez GuillaumeGomez mentioned this issue Nov 22, 2018
Merged
pietroalbini added a commit to pietroalbini/rust that referenced this issue Nov 25, 2018
@pietroalbini
Rollup merge of rust-lang#56176 - GuillaumeGomez:panic-setup-msg, r=n…
686257c 
…agisa

Panic setup msg

Fixes rust-lang#56088.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ehuss @rodrigorc