-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edition idioms: Incorrect suggestion for removing extern crate ignore;
#56326
Labels
A-edition-2018-lints
Area: Lints supporting the 2018 edition
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
Comments
alexcrichton
added
the
A-edition-2018-lints
Area: Lints supporting the 2018 edition
label
Nov 28, 2018
illicitonion
added a commit
to twitter/pants
that referenced
this issue
Dec 5, 2018
alexcrichton
added
the
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
label
Jan 7, 2019
bors
added a commit
that referenced
this issue
Jan 12, 2019
Stabilize `uniform_paths` Address all the things described in #56417. Assign visibilities to `macro_rules` items - `pub` to `macro_export`-ed macros and `pub(crate)` to non-exported macros, these visibilities determine how far these macros can be reexported with `use`. Prohibit use of reexported inert attributes and "tool modules", after renaming (e.g. `use inline as imported_inline`) their respective tools and even compiler passes won't be able to recognize and properly check them. Also turn use of uniform paths in 2015 macros into an error, I'd prefer to neither remove nor stabilize them right away because I still want to make some experiments in this area (uniform path fallback was added to 2015 macros used on 2018 edition in #56053 (comment)). UPDATE: The last commit also stabilizes the feature `uniform_paths`. Closes #53130 Closes #55618 Closes #56326 Closes #56398 Closes #56417 Closes #56821 Closes #57252 Closes #57422
bors
added a commit
that referenced
this issue
Jan 12, 2019
Stabilize `uniform_paths` Address all the things described in #56417. Assign visibilities to `macro_rules` items - `pub` to `macro_export`-ed macros and `pub(crate)` to non-exported macros, these visibilities determine how far these macros can be reexported with `use`. Prohibit use of reexported inert attributes and "tool modules", after renaming (e.g. `use inline as imported_inline`) their respective tools and even compiler passes won't be able to recognize and properly check them. Also turn use of uniform paths in 2015 macros into an error, I'd prefer to neither remove nor stabilize them right away because I still want to make some experiments in this area (uniform path fallback was added to 2015 macros used on 2018 edition in #56053 (comment)). UPDATE: The last commit also stabilizes the feature `uniform_paths`. Closes #53130 Closes #55618 Closes #56326 Closes #56398 Closes #56417 Closes #56821 Closes #57252 Closes #57422
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-edition-2018-lints
Area: Lints supporting the 2018 edition
A-suggestion-diagnostics
Area: Suggestions generated by the compiler applied by `cargo fix`
Given this code:
If applied, though, the suggestion yields:
First reported at rust-lang/cargo#6353 along with a suggestion of how to fix it
The text was updated successfully, but these errors were encountered: