Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide a way to disable rust's usage of RPATH #5644

Closed
thestinger opened this issue Mar 31, 2013 · 1 comment
Closed

provide a way to disable rust's usage of RPATH #5644

thestinger opened this issue Mar 31, 2013 · 1 comment
Milestone
0.6

Comments

@thestinger
Copy link
Contributor

This is really a bad thing for packages that are intended to be installed globally, and can be a security issue. It isn't in this case because this build was done inside a container + chroot and the RPATH is a directory in / that won't exist.

rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/bin/rust')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/bin/rustc')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/bin/rusti')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/bin/rustdoc')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/bin/rustpkg')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/libstd-4782a756585a81-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/librustc-c84825241471686d-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/libcore-c3ca5d77d81b46c1-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/librusti-5047c7f210c7cac8-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/librust-39583f72884834e3-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage1/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/libsyntax-84efebcb12c867a2-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/rustc/x86_64-unknown-linux-gnu/lib/libstd-4782a756585a81-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/rustc/x86_64-unknown-linux-gnu/lib/librustc-c84825241471686d-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/rustc/x86_64-unknown-linux-gnu/lib/libcore-c3ca5d77d81b46c1-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/rustc/x86_64-unknown-linux-gnu/lib/librusti-5047c7f210c7cac8-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/rustc/x86_64-unknown-linux-gnu/lib/librust-39583f72884834e3-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/rustc/x86_64-unknown-linux-gnu/lib/librustdoc-1ac3c0763957e4b0-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/rustc/x86_64-unknown-linux-gnu/lib/libsyntax-84efebcb12c867a2-0.6.so')
rust E: Insecure RPATH '/build/src/rust-0.6/x86_64-unknown-linux-gnu/stage2/lib/rustc/x86_64-unknown-linux-gnu/lib' in file ('usr/lib/rustc/x86_64-unknown-linux-gnu/lib/librustpkg-795073e423d025b-0.6.so')

For reference: http://wiki.debian.org/RpathIssue
@brson
Copy link
Contributor

brson commented Mar 31, 2013

Duplicate of #5219

@brson brson closed this as completed Mar 31, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue May 27, 2020
@bors
Auto merge of rust-lang#5647 - ebroto:5644_allow_ptr_arg_in_arg_posit…
2a6cfa7 
…ion, r=flip1995

ptr_arg: honor `allow` attribute on arguments

The `intravisit::Visitor` impl for `LateContextAndPass` only takes into account the attributes of a function parameter inside the `check_param` method. `ptr_arg` starts its heuristics at `check_item` / `check_impl_item` / `check_trait_item`, so the `allow` is not taken into account automatically.

changelog: ptr_arg: honor `allow` attribute on arguments

Fixes rust-lang#5644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@brson @thestinger