core::repr assumes it knows how enums are represented #5652
Comments
ghost
assigned 
bors
added a commit
that referenced
this issue
Apr 15, 2013
This takes care of one of the last remnants of assumptions about enum layout. A type visitor is now passed a function to read a value's discriminant, then accesses fields by being passed a byte offset for each one. The latter may not be fully general, despite the constraints imposed on representations by borrowed pointers, but works for any representations currently planned and is relatively simple. Closes #5652.
|
closed by 3809a04 |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
May 27, 2020
Fail bors on missing changelog Bors stopped failed if the changelog was missing. Instead it waited 2h (?) and then timed out. changelog: none
This was referenced Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
TyVisitorimpl incore::reprassumes it knows how enums are laid out, and can determine this based only on the number of variants. This will break if we want to do anything interesting with representations. In particular, this blocks #1271 (nullable pointers, which I have mostly implemented aside from this) and #1647 (smaller discriminants).The text was updated successfully, but these errors were encountered: