Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typeck::check::_match emits derived errors #5658

Closed
catamorphism opened this issue Apr 1, 2013 · 3 comments
Closed

typeck::check::_match emits derived errors #5658

catamorphism opened this issue Apr 1, 2013 · 3 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-typesystem Area: The type system

Comments

@catamorphism
Copy link
Contributor

The pattern-match-checking code potentially prints out derived errors because it doesn't check for ty_err like the rest of the typechecker does. I have a branch that almost fixes this but I got distracted working on higher-priority bugs.
@ghost ghost assigned catamorphism Apr 1, 2013
@catamorphism catamorphism mentioned this issue Apr 1, 2013
Closed
@catamorphism catamorphism mentioned this issue Apr 9, 2013
Closed
@catamorphism
Copy link
Contributor Author

Fixed, pending #6103

@emberian
Copy link
Member

@catamorphism is this fixed now? #6103 landed

@catamorphism
Copy link
Contributor Author

Oops, forgot to close this.

@catamorphism catamorphism removed their assignment Jun 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 11, 2020
@bors
Auto merge of rust-lang#5889 - ebroto:5886_or_fun_call_const_0_args, …
1683189 
…r=Manishearth

Avoid or_fun_call for const_fn with no args

Based on rust-lang#5682 by @lzutao

This avoids a subset of false positives, specifically those related to `const fn`s that take no arguments.
For the rest, a much more involved fix would be needed, see rust-lang/rust-clippy#5682 (comment).

So this does *not* solve rust-lang#5658

changelog: Avoid triggering [`or_fun_call`] with `const fn`s that take no arguments.

Fixes rust-lang#5886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-typesystem Area: The type system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catamorphism @emberian