Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edition compatibility: No warning emitted for crate/macro of the same name #56684

Closed
alexcrichton opened this issue Dec 10, 2018 · 1 comment
Closed
Labels
A-edition-2018-lints Area: Lints supporting the 2018 edition A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`

Comments

@alexcrichton
Copy link
Member

Originally reported upstream this code:

#![warn(rust_2018_compatibility)]
#![allow(unused_imports)]

#[macro_use]
extern crate toml; // 0.4.8

mod x {
    use toml;
}

when compiled emits no warnings, but when compiled in the 2018 edition fails to compile.

This appears to have something to do with the fact that the toml crate has a toml macro perhaps? It seems unclear!

@alexcrichton alexcrichton added the A-edition-2018-lints Area: Lints supporting the 2018 edition label Dec 10, 2018
@alexcrichton alexcrichton added the A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` label Jan 7, 2019
@ehuss
Copy link
Contributor

ehuss commented Mar 28, 2019

I think this can be closed. This was fixed in 1.32 via #56759.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2018-lints Area: Lints supporting the 2018 edition A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix`
Projects
None yet
Development

No branches or pull requests

3 participants