Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rustpkg needs to be testable #5683

Closed
graydon opened this issue Apr 2, 2013 · 5 comments
Closed

Rustpkg needs to be testable #5683

graydon opened this issue Apr 2, 2013 · 5 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Milestone
0.7

Comments

@graydon
Copy link
Contributor

graydon commented Apr 2, 2013

Sub-bug of #5677

Currently rustpkg is not testable. We need a test driver for it that sets up test packages and tries to perform various actions with them. This should include at minimum:

  • a git-sourced package (filesystem-local repo is ok)
  • a tarball / curl package (likewise)
  • building, installing, testing, running a binary
  • multiple workspaces and RUST_PATH
  • single-crate library and binary packages
  • multi-crate library and binary packages
  • dependencies between multiple packages
  • use of pkg.rs custom build logic
  • building a C library
@ghost ghost assigned catamorphism Apr 2, 2013
@graydon graydon mentioned this issue Apr 3, 2013
Closed
@catamorphism
Copy link
Contributor

We agreed to have #[test]s that shell out with program_output to call rustpkg, for now. Eventually we'll be rewriting compiletest to use workcache and can repurpose that.

@catamorphism catamorphism mentioned this issue Jun 15, 2013
Closed
@catamorphism
Copy link
Contributor

#5683 partly solves this, but eventually we still want to have a test runner that doesn't spawn separate processes. In addition, tests for building a C library, custom build logic, multi-crate packages, multiple workspaces, RUST_PATH, testing, running, and tarball/curl packages still need to be added.

bors added a commit that referenced this issue Jun 15, 2013
@bors
auto merge of #7148 : catamorphism/rust/rustpkg_tests, r=graydon
eac0200 
r? @graydon Automate more tests described in the commands.txt file,
and add infrastructure for running them. Right now, tests shell
out to call rustpkg. This is not ideal.

Goes part of the way towards addressing #5683
@catamorphism
Copy link
Contributor

I'm going to split this up into separate issues

@catamorphism
Copy link
Contributor

C libraries: #6403
Custom build logic: #7239
Multi-crate packages: #7240
Multiple workspaces: #7241
RUST_PATH: #5682
rust test and rust run: #7242
tarball/curl packages: #7243

@catamorphism
Copy link
Contributor

Closing in favor of individual issues

This was referenced Oct 22, 2022
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc E-hard Call for participation: Hard difficulty. Experience needed to fix: A lot.
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
3 participants
@graydon @steveklabnik @catamorphism