Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_layout_scalar_valid_range_start doesn't prevent unused_unsafe lint #57183

Closed
varkor opened this issue Dec 28, 2018 · 5 comments
Closed
Assignees
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@varkor
Copy link
Member

varkor commented Dec 28, 2018

Edit: this is just a stage 0 problem, so we can conditionally ignore those warnings for now.


rustc_layout_scalar_valid_range_start requires unsafe, but does not cause unsafe blocks to be counted as "used", meaning that the following:

Some(unsafe { $Ty(n) })

is warned as unused, but removing the unsafe causes an error.

@varkor varkor added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Dec 28, 2018
@varkor
Copy link
Member Author

varkor commented Dec 28, 2018

Another issue is that rustc_layout_scalar_valid_range_start attributes are also considered unused when they are not.

@oli-obk oli-obk self-assigned this Dec 28, 2018
@varkor varkor closed this as completed Dec 28, 2018
@pietroalbini
Copy link
Member

Why is this closed? It's still present (encountered it during beta promotion).

@oli-obk
Copy link
Contributor

oli-obk commented Jan 17, 2019

Shouldn't beta promotion fix these warnings? stage1 has warnings denied and compiles libcore and libstd just fine.

@pietroalbini
Copy link
Member

Not on the beta itself, apparently.

@oli-obk
Copy link
Contributor

oli-obk commented Jan 17, 2019

That issue is really tracked in #57178

@oli-obk oli-obk closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Development

No branches or pull requests

3 participants