Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression from stable to beta: examples dir in workspace top-level #57524

Closed
jonhoo opened this issue Jan 11, 2019 · 4 comments
Closed

Regression from stable to beta: examples dir in workspace top-level #57524

jonhoo opened this issue Jan 11, 2019 · 4 comments

Comments

@jonhoo
Copy link
Contributor

jonhoo commented Jan 11, 2019

In tower, we have a root-level examples/ directory in a workspace. This means that we also have to list [dev-dependencies] in the root-level Cargo.toml. This works just fine on the current stable (1.31.1), but fails to compile on 1.32 beta and nightly with:

error: failed to parse manifest at `/home/jon/dev/others/tower/Cargo.toml`

Caused by:
  virtual manifests do not specify [dev-dependencies]

Seems like an unwanted regression from stable?
@ehuss
Copy link
Contributor

ehuss commented Jan 11, 2019

I'm not sure if I understand your setup. How is examples/channel_service.rs used? Cargo has never read dependencies from a virtual manifest, so an error was added to indicate the format is not valid (rust-lang/cargo#6276).

@jonhoo
Copy link
Contributor Author

jonhoo commented Jan 11, 2019

I'll leave that question to @carllerche as I'm not the one who set up the crate :)

@jonhoo jonhoo mentioned this issue Jan 18, 2019
Merged
jonhoo pushed a commit to tower-rs/tower that referenced this issue Jan 19, 2019
@LucioFranco @jonhoo
Add initial base tower crate (#149)
e6a3f76 
This adds the inital base tower crate, as of right now it contains
nothing and is only needed to ensure that cargo workspaces can
properly compile with rust 1.32.

See also rust-lang/rust#57524. Previously, the examples were
never even compiled.
@jonas-schievink
Copy link
Contributor

Should this issue be moved to Cargo instead?

@jonas-schievink
Copy link
Contributor

jonas-schievink commented Apr 16, 2019 •
edited
Loading

Closing in favor of a Cargo issue, but I think this is intentional and never actually worked (the section was just ignored)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ehuss @jonhoo @jonas-schievink