Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

-ized/-ised spelling inconsistency in AST #57773

Closed
zackmdavis opened this issue Jan 20, 2019 · 1 comment · Fixed by #57798
Closed

-ized/-ised spelling inconsistency in AST #57773

zackmdavis opened this issue Jan 20, 2019 · 1 comment · Fixed by #57798
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@zackmdavis
Copy link
Member

(A tiny spelling nit I noticed while reviewing #57768; may be suitable for a new contributor to practice getting started with building rustc. I think we prefer the American spelling -ized, but maybe someone could confirm this?)

rust/src/libsyntax/ast.rs

Line 139 in 0c0c585

Parenthesized(ParenthesisedArgs),

@zackmdavis zackmdavis added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Jan 20, 2019
@jonas-schievink
Copy link
Contributor

Yes, AFAIK we use American spelling everywhere (as do most projects).

@hellow554 hellow554 mentioned this issue Jan 21, 2019
Merged
hellow554 pushed a commit to hellow554/rust that referenced this issue Jan 21, 2019
Corrected spelling inconsistency
bb33f89 
resolves rust-lang#57773
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 21, 2019
@GuillaumeGomez
Rollup merge of rust-lang#57798 - hellow554:master, r=davidtwco
79f57aa 
Corrected spelling inconsistency

resolves rust-lang#57773
hellow554 pushed a commit to hellow554/rust that referenced this issue Jan 22, 2019
Corrected spelling inconsistency
051835b 
resolves rust-lang#57773
Centril added a commit to Centril/rust that referenced this issue Jan 22, 2019
@Centril
Rollup merge of rust-lang#57798 - hellow554:master, r=davidtwco
8c55115 
Corrected spelling inconsistency

resolves rust-lang#57773
VardhanThigle pushed a commit to jethrogb/rust that referenced this issue Jan 31, 2019
Corrected spelling inconsistency
7bff962 
resolves rust-lang#57773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Corrected spelling inconsistency hellow554/rust
2 participants
@zackmdavis @jonas-schievink