Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta standard library docs do not show signature for linked methods #57814

Closed
tspiteri opened this issue Jan 21, 2019 · 6 comments
Closed

Beta standard library docs do not show signature for linked methods #57814

tspiteri opened this issue Jan 21, 2019 · 6 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@tspiteri
Copy link
Contributor

For example, https://doc.rust-lang.org/beta/std/primitive.i8.html#method.min_value shows:
screenshot_2019-01-21 i8 - rust

In nightly, the signature is shown but unhighlighted, for example https://doc.rust-lang.org/nightly/std/primitive.i8.html#method.min_value shows:
screenshot_2019-01-21 i8 - rust 1
@Centril Centril added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Jan 22, 2019
@hellow554 hellow554 mentioned this issue Jan 22, 2019
Closed
@hellow554
Copy link
Contributor

Related: #57628

@QuietMisdreavus
Copy link
Member

@GuillaumeGomez #57646 needs to be backported, but it also looks like the yellow highlight doesn't show any more?

@QuietMisdreavus QuietMisdreavus mentioned this issue Jan 22, 2019
Merged
@GuillaumeGomez
Copy link
Member

Ah, a new issue. I'll fix it quickly.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jan 23, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jan 28, 2019
@Centril
Rollup merge of rust-lang#57859 - GuillaumeGomez:fix-background, r=Qu…
757abfc 
…ietMisdreavus

Fix invalid background color

As discussed in rust-lang#57814.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Jan 28, 2019
@Centril
Rollup merge of rust-lang#57859 - GuillaumeGomez:fix-background, r=Qu…
b1b67cd 
…ietMisdreavus

Fix invalid background color

As discussed in rust-lang#57814.

r? @QuietMisdreavus
@tspiteri
Copy link
Contributor Author

@GuillaumeGomez This is fixed in the nightly page, but not in the beta page. Is this going to be fixed in beta before the 1.33.0 release?

@GuillaumeGomez
Copy link
Member

It hasn't been backported? Urg...

@tspiteri
Copy link
Contributor Author

Seems to be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Centril @hellow554 @GuillaumeGomez @QuietMisdreavus @tspiteri