Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: broken link for logo on settings page #57892

Closed
dhardy opened this issue Jan 25, 2019 · 1 comment
Closed

rustdoc: broken link for logo on settings page #57892

dhardy opened this issue Jan 25, 2019 · 1 comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@dhardy
Copy link
Contributor

dhardy commented Jan 25, 2019

Running cargo doc locally builds a settings.html page with the Rust project logo in the top-left corner. This logo URL and its link target seem to be hard-coded?

<a href='.//index.html'><img src='https://www.rust-lang.org/logos/rust-logo-128x128-blk.png' alt='logo' width='100'></a>

The link target index.html does not exist. (IIRC the rustdoc team made a deliberate decision not to generate this page, though personally I think it should exist since multiple crates may be documented from the same repo.)

I believe this is a change in a very recent version of the nightly compiler. Our hosted doc does not include the logo, presumably because it has not been updated since (cargo deadlinks spots the broken URL and makes the test fail).

Also see: deadlinks/cargo-deadlinks#36
@dhardy dhardy mentioned this issue Jan 25, 2019
Merged
@Centril Centril added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 25, 2019
@dhardy dhardy mentioned this issue Jan 25, 2019
Closed
@GuillaumeGomez
Copy link
Member

Taking a look.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jan 31, 2019
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Feb 7, 2019
@GuillaumeGomez
Rollup merge of rust-lang#58028 - GuillaumeGomez:fix-settings-image-l…
1a99a32 
…ink, r=QuietMisdreavus

Fix image link in the settings menu

Fixes rust-lang#57892.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dhardy @Centril @GuillaumeGomez