Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rustdoc-js unit-test for substring after removal of unstable API #58331

Closed
Matthias247 opened this issue Feb 9, 2019 · 1 comment · Fixed by #59711
Closed

Fix rustdoc-js unit-test for substring after removal of unstable API #58331

Matthias247 opened this issue Feb 9, 2019 · 1 comment · Fixed by #59711
Assignees
@GuillaumeGomez
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Matthias247
Copy link
Contributor

As discovered in #57992, the test in https://github.com/rust-lang/rust/blob/master/src/test/rustdoc-js/substring.js referenced an API unstable, which lead to a breaking test when the API was removed.

Per discussion with @GuillaumeGomez I am removing the test inside #57992 in order to unblock that change. The test should be fixed afterwards. Ideally without referencing unstable APIs.
@Matthias247 Matthias247 mentioned this issue Feb 9, 2019
Merged
@jonas-schievink jonas-schievink added A-testsuite Area: The testsuite used to check the correctness of rustc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 9, 2019
@GuillaumeGomez
Copy link
Member

The simplest way to fix this issue is to make the substring search outside of the std libs. It'll be easier when #58330 will get merged.

@GuillaumeGomez GuillaumeGomez self-assigned this Feb 9, 2019
@GuillaumeGomez GuillaumeGomez mentioned this issue Apr 4, 2019
Merged
cramertj added a commit to cramertj/rust that referenced this issue Apr 11, 2019
@cramertj
Rollup merge of rust-lang#59711 - GuillaumeGomez:substring-test, r=Qu…
b9a99b9 
…ietMisdreavus

Add back the substring test

Fixes rust-lang#58331.

r? @QuietMisdreavus
Centril added a commit to Centril/rust that referenced this issue Apr 12, 2019
@Centril
Rollup merge of rust-lang#59711 - GuillaumeGomez:substring-test, r=Qu…
d77b7d9 
…ietMisdreavus

Add back the substring test

Fixes rust-lang#58331.

r? @QuietMisdreavus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add back the substring test GuillaumeGomez/rust
3 participants
@jonas-schievink @GuillaumeGomez @Matthias247