Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug-info tests are broken after LLVM upgrade #5836

Closed
brson opened this issue Apr 11, 2013 · 7 comments
Closed

debug-info tests are broken after LLVM upgrade #5836

brson opened this issue Apr 11, 2013 · 7 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)

Comments

@brson
Copy link
Contributor

brson commented Apr 11, 2013

http://buildbot.rust-lang.org/builders/auto-linux/builds/808/steps/test/logs/stdio

(Update from Felix: the link above is dead.)
@ghost ghost assigned brson Apr 11, 2013
@jdm
Copy link
Contributor

jdm commented Apr 11, 2013

According to echristo, the debug metadata node format changed and the docs weren't updated. Easiest way to unbreak it is to refer to the Clang source as reference.

@emberian
Copy link
Member

This would be very nice to have working again.

@pnkfelix pnkfelix mentioned this issue May 29, 2013
Closed
@pnkfelix
Copy link
Member

Nominating for milestone #3, "feature complete."

Though if we expect any tools out there to make use of debug-info, then maybe we should be filing this under milestone #2: "backward compatible." (If I could some way to justify getting it into milestone #1, I would...)

@pnkfelix
Copy link
Member

Actually, this bug should be clarified: Is this bug pointing out that:

  • there are correct tests that are failing but are currently ignored? (Which is my assumption based on the fact that my attempt to use -Z debug-info yielded assertion failures from llvm.)
  • Or is it saying that the current tests are failing because they are not good tests (e.g. that they make incorrect assumptions about the debug info.)

@pnkfelix pnkfelix mentioned this issue May 29, 2013
Closed
@pnkfelix
Copy link
Member

(Moving my nomination request to #6814.)

@jdm
Copy link
Contributor

jdm commented May 29, 2013

The bug is pointing out the first point in your list.

@vadimcn vadimcn mentioned this issue Jun 14, 2013
Closed
bors added a commit that referenced this issue Jun 17, 2013
@bors
auto merge of #7134 : vadimcn/rust/DIBuilder, r=jdm
4bf074c 
This commit fixes rustc's debug info generation and turns debug-info tests back on.

The old generator used to write out LLVM metadata directly, however it seems that debug metadata format is not stable and keeps changing from release to release.  So I wrapped LLVM's official debug info API - the DIBuilder class, and now rustc will use that.

One bit of old functionality that still doesn't work, is debug info for function arguments.  Someone more familiar with the compiler guts will need to look into that.

Also, unfortunately, debug info is still won't work on Windows,- due to a LLVM bug (http://llvm.org/bugs/show_bug.cgi?id=16249).

Resolves issues #5836, #5848, #6814
@jdm
Copy link
Contributor

jdm commented Jun 19, 2013

Fix0red.

@jdm jdm closed this as completed Jun 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jdm @brson @pnkfelix @emberian