Skip to content

Add support for rdrand Ivy Bridge instruction #5857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Apr 12, 2013 · 6 comments
Closed

Add support for rdrand Ivy Bridge instruction #5857

brson opened this issue Apr 12, 2013 · 6 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Apr 12, 2013

When running on Ivy Bridge chips our rand module can just defer to the dedicated random number generator.
@pnkfelix
Copy link
Member

pnkfelix commented Jul 2, 2013

visited for bug triage on 2013 july 2.

@huonw
Copy link
Member

huonw commented Jul 2, 2013

I'm going to include this as part of my std::rand rewrite, which I'm hoping to get mergeable in the next week or two.

@catamorphism
Copy link
Contributor

@huonw Did this end up landing yet?

@huonw
Copy link
Member

huonw commented Aug 12, 2013

Not yet.

@brson
Copy link
Contributor Author

brson commented Oct 18, 2013

I'm not entirely sure we should just defer random number generation to hw. The linux kernel at least does not trust it, and just uses it as one entropy source of many.

@huonw
Copy link
Member

huonw commented Oct 18, 2013

@brson I agree in light of the recent NSA + RDRAND scandal & the linux kernel's opinion of it. We can just defer to the OS for "strong" random numbers and let it decide about the quality of whatever sources of randomness it has, so we don't have to keep up with which vendors have trustworthy CPU RNGs etc.

(FWIW, I tried implemented this, but I never quite got the asm! to work 100% reliably.)

Closing this as wontfix, feel free to reopen if someone really thinks this is necessary.

@huonw huonw closed this as completed Oct 18, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Aug 11, 2020
@bors
Auto merge of rust-lang#5857 - tmiasko:try-err-poll, r=matthiaskrgr
3d7e3fd 
try_err: Consider Try impl for Poll when generating suggestions

There are two different implementation of `Try` trait for `Poll` type:
`Poll<Result<T, E>>` and `Poll<Option<Result<T, E>>>`. Take them into
account when generating suggestions.

For example, for `Err(e)?` suggest either `return Poll::Ready(Err(e))` or
`return Poll::Ready(Some(Err(e)))` as appropriate.

Fixes rust-lang#5855

changelog: try_err: Consider Try impl for Poll when generating suggestions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brson @pnkfelix @catamorphism @huonw