Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No docs for String on stable? #58827

Closed
matklad opened this issue Mar 1, 2019 · 12 comments
Closed

No docs for String on stable? #58827

matklad opened this issue Mar 1, 2019 · 12 comments
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@matklad
Copy link
Member

matklad commented Mar 1, 2019

Hi! Looks like docs for std string methods are missing on stable release?

https://doc.rust-lang.org/std/string/struct.String.html#method.as_bytes

37906c37-5439-48fd-b536-8562abd30309

THe methods section is empty :(

Everything works ok for beta.

@matklad
Copy link
Member Author

matklad commented Mar 1, 2019

Note that the screenshot was taken from iPad. I know checked using Firefox on linux, and the methods are there.

@hellow554
Copy link
Contributor

hellow554 commented Mar 1, 2019

This is the same for other structs, e.g. std::sync::Arc (Firefox 64, Windows)

grafik

@matklad can you ping the doc team about this?

@matklad
Copy link
Member Author

matklad commented Mar 1, 2019

cc @rust-lang/docs :)

Note that it does work for some people. I wonder if this is some temporary internet caches thing?

@jonas-schievink jonas-schievink added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-bug Category: This is a bug. labels Mar 1, 2019
@jonas-schievink
Copy link
Contributor

Looks like a rustdoc problem more than anything. Did you try clearing your caches? I know I have to do that after pretty much every stable release or stuff breaks for me.

cc @rust-lang/rustdoc

@GuillaumeGomez
Copy link
Member

I have tested and I can't reproduce it on my linux's chrome and firefox. So I don't know what's going on and I don't have an ipad to test specifically what's wrong on this platform...

@hellow554
Copy link
Contributor

It was indeed a caching problem. Sorry for the noise :/ Although it shouldn't happen IMHO.

@jonas-schievink
Copy link
Contributor

Yes, it would be nice to find a proper solution for this. I've also opened issues in the past that were just due to a stale browser cache.

@GuillaumeGomez
Copy link
Member

We could by changing the name of the script files like docs.rs does. Where could I change it @rust-lang/infra ?

@kennytm
Copy link
Member

kennytm commented Mar 1, 2019

Isn't the script path hard-coded in src/librustdoc/html/layout.rs?

@GuillaumeGomez
Copy link
Member

It's generated and can be changed (we have options for that in rustdoc).

@QuietMisdreavus
Copy link
Member

Could we just start adding a --resource-suffix in bootstrap with something that matches the version string (or just the latest commit if necessary)? That would ensure that the filename is different so that the CDN wouldn't serve old files to the wrong version's docs.

@GuillaumeGomez
Copy link
Member

@QuietMisdreavus I did. Look at #58848. :)

Centril added a commit to Centril/rust that referenced this issue Mar 10, 2019
…Mark-Simulacrum

Prevent cache issues on version updates

Fixes rust-lang#58827.

cc @rust-lang/infra
Centril added a commit to Centril/rust that referenced this issue Mar 10, 2019
…Mark-Simulacrum

Prevent cache issues on version updates

Fixes rust-lang#58827.

cc @rust-lang/infra
Centril added a commit to Centril/rust that referenced this issue Mar 10, 2019
…Mark-Simulacrum

Prevent cache issues on version updates

Fixes rust-lang#58827.

cc @rust-lang/infra
Centril added a commit to Centril/rust that referenced this issue Mar 10, 2019
…Mark-Simulacrum

Prevent cache issues on version updates

Fixes rust-lang#58827.

cc @rust-lang/infra
Centril added a commit to Centril/rust that referenced this issue Mar 11, 2019
…Mark-Simulacrum

Prevent cache issues on version updates

Fixes rust-lang#58827.

cc @rust-lang/infra
kennytm added a commit to kennytm/rust that referenced this issue Mar 11, 2019
…Mark-Simulacrum

Prevent cache issues on version updates

Fixes rust-lang#58827.

cc @rust-lang/infra
Centril added a commit to Centril/rust that referenced this issue Mar 28, 2019
…Mark-Simulacrum,ollie27

Prevent cache issues on version updates

Fixes rust-lang#58827.

cc @rust-lang/infra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants