Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustc: remove unnecessary extern_prelude logic from ty::item_path #59100

Open
Dylan-DPC-zz opened this issue Mar 11, 2019 · 0 comments
Open

rustc: remove unnecessary extern_prelude logic from ty::item_path #59100

Dylan-DPC-zz opened this issue Mar 11, 2019 · 0 comments
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Dylan-DPC-zz
Copy link

From #56655 :

The checks added in 02357e4 effectively turned crate::std into std, but they were too general (affecting any crate::foo where foo was in the extern prelude, not just extern crates), and unnecessary, as only the extern crates created by "std injection" need any special-casing.
Since this only affects the user-facing "relative" mode, it shouldn't have interactions with linking, and the only observable effect should be sometimes-shorter paths in diagnostics.

Creating this issue as a tracking issue since the PR is closed due to inactivity.
@Dylan-DPC-zz Dylan-DPC-zz added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Mar 11, 2019
@Enselic Enselic added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Enselic @Dylan-DPC-zz