-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NonZero signed variants not available in std #59834
Labels
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
Comments
Mark-Simulacrum
added
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
and removed
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
labels
Apr 9, 2019
bors
added a commit
that referenced
this issue
Apr 10, 2019
[stable] Cherry-pick stdlib fix Cherry-picked: * #59835: Re-export NonZero signed variant in std r? @Mark-Simulacrum cc #59834 @rust-lang/release
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this issue
Apr 11, 2019
…acrum Re-export NonZero signed variant in std cc rust-lang#59834
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 12, 2019
…acrum Re-export NonZero signed variant in std Closes rust-lang#59834 .
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 13, 2019
…acrum Re-export NonZero signed variant in std Closes rust-lang#59834 .
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 13, 2019
…acrum Re-export NonZero signed variant in std Closes rust-lang#59834 .
Centril
added a commit
to Centril/rust
that referenced
this issue
Apr 13, 2019
…acrum Re-export NonZero signed variant in std Closes rust-lang#59834 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
NonZero
signed variants are not re-exported instd
here: https://github.com/rust-lang/rust/blob/master/src/libstd/num.rs#L15We should duplicate that line and re-export them.
cc @rust-lang/release @rust-lang/libs -- this will likely slip into 1.34, but we will backport the fix into 1.35
The text was updated successfully, but these errors were encountered: