Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Pin::{into_inner, into_inner_unchecked} (feature pin_into_inner) #60245

Closed
Nemo157 opened this issue Apr 24, 2019 · 9 comments · Fixed by #63985
Closed

Tracking issue for Pin::{into_inner, into_inner_unchecked} (feature pin_into_inner) #60245

Nemo157 opened this issue Apr 24, 2019 · 9 comments · Fixed by #63985
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@Nemo157
Copy link
Member

Nemo157 commented Apr 24, 2019

This is a tracking issue for Pin::into_inner and Pin::into_inner_unchecked, proposed and implemented in #60165.
@Nemo157
Copy link
Member Author

Nemo157 commented Apr 24, 2019

@rustbot modify labels to T-libs, C-tracking-issue.

@rustbot rustbot added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 24, 2019
@jonas-schievink jonas-schievink added the B-unstable Blocker: Implemented in the nightly compiler and unstable. label Apr 24, 2019
@ghedo ghedo mentioned this issue Jul 2, 2019
Closed
@cramertj
Copy link
Member

cramertj commented Jul 2, 2019

@rust-lang/libs These have been available on nightly for some time with no controversy. They're pretty useful when working with Pin-- do y'all have anything you'd like to see here before merging?

@alexcrichton
Copy link
Member

Let's see! Proposed APIs look to be:

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Jul 3, 2019 •
edited by sfackler
Loading

Team member @alexcrichton has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 3, 2019
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Aug 7, 2019
@rfcbot
Copy link

rfcbot commented Aug 7, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Aug 7, 2019
@rfcbot
Copy link

rfcbot commented Aug 17, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Aug 17, 2019
@alexcrichton

This comment has been minimized.

Sign in to view
@cramertj
Copy link
Member

@alexcrichton I don't think you can r+ issues ;)

@ghedo ghedo mentioned this issue Aug 28, 2019
Merged
@ghedo
Copy link
Contributor

ghedo commented Aug 28, 2019

Since this seems to have gone quiet again, I took the liberty of creating #63985 to do the actual stabilization.

Centril added a commit to Centril/rust that referenced this issue Sep 4, 2019
@Centril
Rollup merge of rust-lang#63985 - ghedo:stabilize_pin_into_inner, r=a…
820a380 
…lexcrichton

Stabilize pin_into_inner in 1.39.0

FCP: rust-lang#60245 (comment)

Closes rust-lang#60245
Centril added a commit to Centril/rust that referenced this issue Sep 5, 2019
@Centril
Rollup merge of rust-lang#63985 - ghedo:stabilize_pin_into_inner, r=a…
a721221 
…lexcrichton

Stabilize pin_into_inner in 1.39.0

FCP: rust-lang#60245 (comment)

Closes rust-lang#60245
Centril added a commit to Centril/rust that referenced this issue Sep 5, 2019
@Centril
Rollup merge of rust-lang#63985 - ghedo:stabilize_pin_into_inner, r=a…
d1d511d 
…lexcrichton

Stabilize pin_into_inner in 1.39.0

FCP: rust-lang#60245 (comment)

Closes rust-lang#60245
@bors bors closed this as completed in 820aa5b Sep 5, 2019
@dtacalau dtacalau mentioned this issue Nov 26, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stabilize pin_into_inner in 1.39.0
7 participants
@alexcrichton @Nemo157 @ghedo @jonas-schievink @cramertj @rfcbot @rustbot