Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for Option::flatten #60258

Closed
eopb opened this issue Apr 25, 2019 · 4 comments
Closed

Tracking issue for Option::flatten #60258

eopb opened this issue Apr 25, 2019 · 4 comments
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@eopb
Copy link
Contributor

eopb commented Apr 25, 2019

PR
@jonas-schievink jonas-schievink changed the title Add flatten option to Option<Option<T>> with Into trait or new method. Tracking issue for Option::flatten Apr 25, 2019
@jonas-schievink jonas-schievink added B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Apr 25, 2019
@elahn
Copy link
Contributor

elahn commented Sep 10, 2019

I was trying to flat_map() and found map().flatten() does the trick. This has been on nightly for 4 months, can we stabilise it?

@eopb
Copy link
Contributor Author

eopb commented Sep 10, 2019

@Centril Helped me get this merged. What is the stabilization process?

@Centril
Copy link
Contributor

Centril commented Sep 10, 2019

@ethanboxx I'd just file a PR to stabilize it and we'll ask T-libs to FCP.

@eopb eopb mentioned this issue Sep 24, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Oct 27, 2019
@Centril
Rollup merge of rust-lang#64747 - ethanboxx:master, r=Centril
ad680c3 
Stabilize `Option::flatten`

- PR: rust-lang#60256
- Tracking issue: rust-lang#60258

@elahn

> I was trying to `flat_map()` and found `map().flatten()` does the trick. This has been on nightly for 4 months, can we stabilise it?

@ethanboxx

> @Centril Helped me get this merged. What is the stabilization process?

@Centril

> @ethanboxx I'd just file a PR to stabilize it and we'll ask T-libs to FCP.

So here I am.

I am was unsure what number to put in `since = "-"` so I copied what someone had done in a recent PR.
Centril added a commit to Centril/rust that referenced this issue Oct 28, 2019
@Centril
Rollup merge of rust-lang#64747 - ethanboxx:master, r=Centril
c8eefdf 
Stabilize `Option::flatten`

- PR: rust-lang#60256
- Tracking issue: rust-lang#60258

@elahn

> I was trying to `flat_map()` and found `map().flatten()` does the trick. This has been on nightly for 4 months, can we stabilise it?

@ethanboxx

> @Centril Helped me get this merged. What is the stabilization process?

@Centril

> @ethanboxx I'd just file a PR to stabilize it and we'll ask T-libs to FCP.

So here I am.

I am was unsure what number to put in `since = "-"` so I copied what someone had done in a recent PR.
@Dylan-DPC-zz
Copy link

The feature has been stabilised. Closing this. Thanks :)

dtolnay added a commit to dtolnay/async-trait that referenced this issue Aug 11, 2020
@dtolnay
Raise minimum tested version to 1.40
13c16a4 
1.39 is still supported but tracing-attributes in our test deps assumes 1.40.

    error[E0658]: use of unstable library feature 'option_flattening'
       --> tracing-attributes-0.1.10/src/lib.rs:933:10
        |
    933 |         .flatten();
        |          ^^^^^^^
        |
        = note: for more information, see rust-lang/rust#60258
dtolnay added a commit to dtolnay/async-trait that referenced this issue Aug 11, 2020
@dtolnay
Raise minimum tested version to 1.40
96475de 
1.39 is still supported but tracing-attributes in our test deps assumes 1.40.

    error[E0658]: use of unstable library feature 'option_flattening'
       --> tracing-attributes-0.1.10/src/lib.rs:933:10
        |
    933 |         .flatten();
        |          ^^^^^^^
        |
        = note: for more information, see rust-lang/rust#60258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Centril @jonas-schievink @eopb @elahn @Dylan-DPC-zz