Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove -Ztwo-phase-borrows #60331

Closed
matthewjasper opened this issue Apr 27, 2019 · 1 comment · Fixed by #60347
Closed

Remove -Ztwo-phase-borrows #60331

matthewjasper opened this issue Apr 27, 2019 · 1 comment · Fixed by #60347
Labels
A-NLL Area: Non-lexical lifetimes (NLL) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@matthewjasper
Copy link
Contributor

This flag does nothing, so can be removed from librustc/session/config.rs.

The -Z two-phase-beyond-autoref flag could also be removed, since it will usually result in an ICE rather than anything helpful. Removing this will require a bit more work to remove any usage of the flag.
@matthewjasper matthewjasper added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. A-NLL Area: Non-lexical lifetimes (NLL) labels Apr 27, 2019
@JohnTitor
Copy link
Member

I'd like to work on this.

@JohnTitor JohnTitor mentioned this issue Apr 28, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Apr 28, 2019
@Centril
Rollup merge of rust-lang#60347 - JohnTitor:remove-flags, r=matthewja…
fe52f8e 
…sper

Remove `-Z two-phase-borrows` and `-Z two-phase-beyond-autoref`

fixes rust-lang#60331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-NLL Area: Non-lexical lifetimes (NLL) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove -Z two-phase-borrows and -Z two-phase-beyond-autoref JohnTitor/rust
2 participants
@matthewjasper @JohnTitor