Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#60389 #60398

Closed
rust-highfive opened this issue Apr 30, 2019 · 3 comments
Closed

rls no longer builds after rust-lang/rust#60389 #60398

rust-highfive opened this issue Apr 30, 2019 · 3 comments
Assignees
@Centril @Xanewok
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Contributor

Hello, this is your friendly neighborhood mergebot.
After merging PR #60389, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 30, 2019
@Centril
Copy link
Contributor

Centril commented Apr 30, 2019

Blame ==> #60276 cc @matthewjasper

@phansch
Copy link
Member

phansch commented Apr 30, 2019

Should be fixed by #60399

@Xanewok
Copy link
Member

Xanewok commented May 1, 2019

RLS now builds and is included since 2019-04-30, closing.

@Xanewok Xanewok closed this as completed May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Centril Centril

@Xanewok Xanewok

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Centril @phansch @Xanewok @rust-highfive