You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Generating documentation for a struct with #[derive(Clone)] results in a page with an entry for clone_from with the following HTML:
<h4id='method.clone_from' class="method"><codeid='clone_from.v'>fn <ahref='https://doc.rust-lang.org/nightly/core/clone/trait.Clone.html#method.clone_from' class='fnname'>clone_from</a>(&mut self, source: <aclass="primitive" href="https://doc.rust-lang.org/nightly/std/primitive.reference.html">
&</a>Self)</code><divclass='since' title='Stable since Rust version 1.0.0'>1.0.0</div><aclass='srclink' href='https://doc.rust-lang.org/nightly/src/core/clone.rs.html#131-133' title='goto source code'>[src]</a></h4>
As per remarks on aforementioned bug, the question "Have you confirmed that this doesn't break anything? Would you be able to host a rustdoc build to demonstrate?", the way this breaks for me is far worse than failing a validator test score:
I'm attempting to run the generated HTML though html-tidy, and upon seeing the <h4><div>...</div></h4> structure, warns:
line 9 column 3 - Warning: <div> isn't allowed in <h4> elements
line 9 column 67 - Warning: discarding unexpected </div>
It then appears to "Fix" this by rewriting it as:
<h4>...</h4><div>...</div><h4>...</h4>
And the resulting page is broken beyond usable.
N.B: htmltidy also complains about duplicate anchor names, as per #25001,
line 9 column 3 - Warning: <h4> anchor "method.clone_from" already defined
But that's a seperate issue, and I'd rather have a working HTML tidier so git diff produces something useful between iterations, and then I can more properly see what is going on there.
The text was updated successfully, but these errors were encountered:
See also: #17529
Generating documentation for a struct with
#[derive(Clone)]
results in a page with an entry forclone_from
with the following HTML:As per remarks on aforementioned bug, the question "Have you confirmed that this doesn't break anything? Would you be able to host a rustdoc build to demonstrate?", the way this breaks for me is far worse than failing a validator test score:
I'm attempting to run the generated HTML though html-tidy, and upon seeing the
<h4><div>...</div></h4>
structure, warns:It then appears to "Fix" this by rewriting it as:
And the resulting page is broken beyond usable.
N.B: htmltidy also complains about duplicate anchor names, as per #25001,
But that's a seperate issue, and I'd rather have a working HTML tidier so
git diff
produces something useful between iterations, and then I can more properly see what is going on there.The text was updated successfully, but these errors were encountered: