Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls no longer builds after rust-lang/rust#60435 #60448

Closed
rust-highfive opened this issue May 1, 2019 · 3 comments
Closed

rls no longer builds after rust-lang/rust#60435 #60448

rust-highfive opened this issue May 1, 2019 · 3 comments
Assignees
@Centril @Xanewok
Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #60435, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @Centril, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @Centril, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 1, 2019
@Centril
Copy link
Contributor

Centril commented May 1, 2019

Clippy probably broken by #60417; the fix is just to apply the rename in Clippy as well.

@matthiaskrgr
Copy link
Member

Looking into this...

matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this issue May 1, 2019
@matthiaskrgr
rustup rust-lang/rust#60417
24e856f 
cc rust-lang/rust#60448
@matthiaskrgr matthiaskrgr mentioned this issue May 1, 2019
Closed
bors added a commit to rust-lang/rust-clippy that referenced this issue May 1, 2019
@bors
Auto merge of #4054 - matthiaskrgr:rustup_, r=Manishearth
4da691c 
rustup rust-lang/rust#60417

cc rust-lang/rust#60448

changelog: none
@Xanewok
Copy link
Member

Xanewok commented May 2, 2019

Fixed with #60432

@Xanewok Xanewok closed this as completed May 2, 2019
@matthiaskrgr matthiaskrgr mentioned this issue May 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Centril Centril

@Xanewok Xanewok

Labels
T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@matthiaskrgr @Centril @Xanewok @rust-highfive