Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing documentation for while keyword #60736

Closed
timvisee opened this issue May 11, 2019 · 7 comments · Fixed by #62462
Closed

Missing documentation for while keyword #60736

timvisee opened this issue May 11, 2019 · 7 comments · Fixed by #62462
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@timvisee
Copy link
Contributor

I noticed the while keyword seems to be missing from the official documentation. Keywords like loop and for are documented. Nor does while come up when searching at the top.

Is there a reason for it missing?
@jonas-schievink jonas-schievink added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label May 11, 2019
@jonas-schievink
Copy link
Contributor

These are probably just missing because nobody added documentation for them yet, so feel free to send a PR.

@Centril Centril added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label May 11, 2019
@tesuji
Copy link
Contributor

tesuji commented May 11, 2019

If anyone is interested, you need to add documentation here: https://github.com/rust-lang/rust/blob/master/src/libstd/keyword_docs.rs

@Pulkit07
Copy link
Contributor

I will take care of this one :)

@timvisee
Copy link
Contributor Author

Cool! Wanted to do it, but haven't been able to start on it yet. Perfect if you can take it over.

@Pulkit07 Pulkit07 mentioned this issue May 12, 2019
Closed
@Pulkit07
Copy link
Contributor

Cool! Wanted to do it, but haven't been able to start on it yet. Perfect if you can take it over.

In that case, it will be nice to have you review the PR: #60761.

Pulkit07 added a commit to Pulkit07/rust that referenced this issue May 12, 2019
@Pulkit07
add documentation for the while keyword
dcb1bd1 
while keyword is used to define while loops in rust.

Fixes rust-lang#60736.
@petrochenkov petrochenkov mentioned this issue May 13, 2019
Closed
@hellow554
Copy link
Contributor

Partially resolved by #60817
I think this can be closed in favor of #34601. What do you think @jonas-schievink ?

@jonas-schievink
Copy link
Contributor

#60761 will close this when merged, and it addresses while specifically, so we can also wait for that to land

@JohnTitor JohnTitor mentioned this issue Jul 7, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jul 8, 2019
@Centril
Rollup merge of rust-lang#62462 - JohnTitor:document-while, r=Centril
06c6ea6 
Document `while` keyword

This is a rework of rust-lang#60761.
Closes rust-lang#60736

r? @dtolnay
Centril added a commit to Centril/rust that referenced this issue Jul 8, 2019
@Centril
Rollup merge of rust-lang#62462 - JohnTitor:document-while, r=Centril
60f300a 
Document `while` keyword

This is a rework of rust-lang#60761.
Closes rust-lang#60736

r? @dtolnay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Document while keyword JohnTitor/rust
add documentation for the while keyword Pulkit07/rust
6 participants
@Centril @timvisee @hellow554 @jonas-schievink @Pulkit07 @tesuji