Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditional compilation for native items #610

Closed
brson opened this issue Jul 1, 2011 · 0 comments
Closed

Conditional compilation for native items #610

brson opened this issue Jul 1, 2011 · 0 comments
Assignees
@brson
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@brson
Copy link
Contributor

brson commented Jul 1, 2011

Pending completion of #609, native items should support conditional compilation with the #[cfg(...)] attribute.
@ghost ghost assigned brson Jul 1, 2011
@brson brson closed this as completed in b79ea48 Jul 5, 2011
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@alexcrichton
Add asmjs/wasm32 to CI
22b98de 
Rebase of rust-lang#610 and also move emscripten up much higher in the hierarchy to
ensure that it doesn't have too much of a ripple effect on other platforms.

This involved moving down a good number of definitions, but hopefully was done
with care to not break anything!
keeperofdakeys pushed a commit to keeperofdakeys/rust that referenced this issue Dec 12, 2017
@bors
Auto merge of rust-lang#742 - alexcrichton:wasm, r=alexcrichton
d647164 
Add asmjs/wasm32 to CI

Rebase of rust-lang#610 and also move emscripten up much higher in the hierarchy to
ensure that it doesn't have too much of a ripple effect on other platforms.

This involved moving down a good number of definitions, but hopefully was done
with care to not break anything!
ZuseZ4 pushed a commit to EnzymeAD/rust that referenced this issue Mar 7, 2023
@wsmoses
Fix phi predecessor removal if given placeholder (rust-lang#610)
2cafc87 
* Fix phi predecessor removal if given placeholder

* Fix LLVM 7
celinval added a commit to celinval/rust-dev that referenced this issue Jun 4, 2024
@celinval @tedinski
Fix panic due to wrong intrinsic arguments (rust-lang#533) (rust-lang…
d09f5a4 
…#610)

During codegen of function calls, we were ignoring argument of Unit
type. This was causing a failure due to missing arguments when an
intrinsic or closure was being called with an '()' as an argument.

This change modifies how we deal with Unit types during function
definition and function call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brson brson

Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brson