Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable PGO tests on windows-gnu #61266

Open
mati865 opened this issue May 28, 2019 · 3 comments
Open

Enable PGO tests on windows-gnu #61266

mati865 opened this issue May 28, 2019 · 3 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows-gnu Toolchain: GNU, Operating system: Windows T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@mati865
Copy link
Contributor

mati865 commented May 28, 2019

#61080 enabled profiler for windows-gnu dist jobs and it seems to work.
I didn't know if CI has enough budget to enable it for tests as well so it was left for now but it should be enabled in the future.

Related issue: #59637

@michaelwoerister you might want to add this issue to #59913

@rustbot modify labels: +O-windows-gnu +T-infra
@mati865
Copy link
Contributor Author

mati865 commented May 28, 2019

@rustbot modify labels: +O-windows-gnu +T-infra

@rustbot rustbot added O-windows-gnu Toolchain: GNU, Operating system: Windows T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 28, 2019
@michaelwoerister
Copy link
Member

I'd love it if we ran tests here too. Compiling the profiler runtime shouldn't be a big deal, buildtime-wise. I don't think it should block stabilization though.

@michaelwoerister
Copy link
Member

cc @rust-lang/infra

@jonas-schievink jonas-schievink added the A-testsuite Area: The testsuite used to check the correctness of rustc label May 28, 2019
@mati865 mati865 mentioned this issue May 28, 2019
Closed
@mati865 mati865 mentioned this issue Aug 5, 2020
Closed
@mati865 mati865 mentioned this issue Aug 24, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Sep 4, 2020
@Dylan-DPC
Rollup merge of rust-lang#75872 - mati865:pgo-tests, r=petrochenkov
27a571f 
Enable some of profiler tests on Windows-gnu

CC rust-lang#61266

Because of force-push GitHub didn't let me reopen rust-lang#75184

Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI.
However we can still test the IR for the proper instrumentation so let's do it.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Sep 4, 2020
@Dylan-DPC
Rollup merge of rust-lang#75872 - mati865:pgo-tests, r=petrochenkov
9178eb0 
Enable some of profiler tests on Windows-gnu

CC rust-lang#61266

Because of force-push GitHub didn't let me reopen rust-lang#75184

Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI.
However we can still test the IR for the proper instrumentation so let's do it.
bors added a commit to rust-lang-ci/rust that referenced this issue Sep 5, 2020
@bors
Auto merge of rust-lang#75872 - mati865:pgo-tests, r=petrochenkov
04f44fb 
Enable some of profiler tests on Windows-gnu

CC rust-lang#61266

Because of force-push GitHub didn't let me reopen rust-lang#75184

Because of the GCC miscompilation, generated binaries either segfault or `.profraw` is malformed. Clang works fine but we can't use it on the CI.
However we can still test the IR for the proper instrumentation so let's do it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-windows-gnu Toolchain: GNU, Operating system: Windows T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable PGO tests on Windows-gnu mati865/rust
4 participants
@mati865 @jonas-schievink @michaelwoerister @rustbot