Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pin projection documentation #61272

Closed
RalfJung opened this issue May 28, 2019 · 0 comments · Fixed by #61878
Closed

Improve pin projection documentation #61272

RalfJung opened this issue May 28, 2019 · 0 comments · Fixed by #61878
Assignees
@RalfJung
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented May 28, 2019 •
edited
Loading

In this forum thread, @shepmaster wonders about the details of pinning projections, in particular when there are multiple fields that can make different choices for being structural or not. The docs could likely be improved for that.

This is just so that we don't forget.
@RalfJung RalfJung self-assigned this May 28, 2019
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels May 28, 2019
@RalfJung RalfJung mentioned this issue Jun 25, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Jun 27, 2019
@Centril
Rollup merge of rust-lang#61878 - RalfJung:pin, r=Dylan-DPC
d5f36b8 
improve pinning projection docs

This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182).

Fixes rust-lang#61272.
Centril added a commit to Centril/rust that referenced this issue Jun 27, 2019
@Centril
Rollup merge of rust-lang#61878 - RalfJung:pin, r=Dylan-DPC
ed8cba1 
improve pinning projection docs

This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182).

Fixes rust-lang#61272.
Centril added a commit to Centril/rust that referenced this issue Jun 27, 2019
@Centril
Rollup merge of rust-lang#61878 - RalfJung:pin, r=Dylan-DPC
7ddfae7 
improve pinning projection docs

This tries to improve the explanation of structural pinning and pinning projections based on [this URLO thread](https://users.rust-lang.org/t/when-is-it-safe-to-move-a-member-value-out-of-a-pinned-future/28182).

Fixes rust-lang#61272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RalfJung RalfJung

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve pinning projection docs RalfJung/rust
2 participants
@RalfJung @jonas-schievink