-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Closed
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsE-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.
Description
Part of #59346
To support LL
lines in the first column of UI test output, we have to make use of the -Z ui-testing
flag and update the annotate-snippet
library.
Relevant FIXME
:
rust/src/librustc_errors/annotate_snippet_emitter_writer.rs
Lines 176 to 179 in 57a3300
// FIXME(#59346): This method is used via the public interface, but setting the `ui_testing` | |
// flag currently does not anonymize line numbers. We would have to add the `maybe_anonymized` | |
// method from `emitter.rs` and implement rust-lang/annotate-snippets-rs#2 in order to | |
// anonymize line numbers. |
- The relevant PR in the annotate-snippet library has been merged and a new
version needs to be released. Once that's done, we have to pass
self.ui_testing
as a second argument toDisplayListFormatter::new
.
This issue has been assigned to @phansch via this comment.
Metadata
Metadata
Assignees
Labels
A-diagnosticsArea: Messages for errors, warnings, and lintsArea: Messages for errors, warnings, and lintsE-help-wantedCall for participation: Help is requested to fix this issue.Call for participation: Help is requested to fix this issue.