assert_eq!() might need a better fail message #6221
Comments
|
Visiting for triage; PR as soon as tests are finished running. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this issue
Feb 25, 2021
Rework use_self impl based on ty::Ty comparison rust-lang#3410 | Take 2 This builds on top of rust-lang#5531 I already reviewed and approved the commits by `@montrivo.` So only the review of my commits should be necessary. I would also appreciate your review `@montrivo,` since you are familiar with the challenges here. Fixes rust-lang#3410 and Fixes rust-lang#4143 (same problem) Fixes rust-lang#2843 Fixes rust-lang#3859 Fixes rust-lang#4734 and fixes rust-lang#6221 Fixes rust-lang#4305 Fixes rust-lang#5078 (even at expression level now 🎉) Fixes rust-lang#3881 and Fixes rust-lang#4887 (same problem) Fixes rust-lang#3909 Not yet: rust-lang#4140 (test added) All the credit for the fixes goes to `@montrivo.` I only refactored and copy and pasted his code. changelog: rewrite [`use_self`] lint and fix multiple (8) FPs. One to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
assert_eq!(left, right)used to fail withfmt!("expected: %?, given: %?", right, left), which was confusing because it was neither clear which of the two parameters ofassert_eqis supposed to be the 'given' and 'expected' value, and because the values got printed out swapped compared to the way the arguments are given.It now fails with
fmt!("left: %? != right: %?", left, right), which, while less confusing, is still kinda unclear because it doesn't contain any description of what happened.The message should probably be more verbose, like
fmt!("expected equal, but left side %? != right side %?", left, right)The text was updated successfully, but these errors were encountered: