Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.36 changes the UnwindSafe impl precondition for HashMap #62301

Closed
CAD97 opened this issue Jul 2, 2019 · 3 comments · Fixed by #62304
Closed

1.36 changes the UnwindSafe impl precondition for HashMap #62301

CAD97 opened this issue Jul 2, 2019 · 3 comments · Fixed by #62304
Labels
A-collections Area: std::collections. C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@CAD97
Copy link
Contributor

CAD97 commented Jul 2, 2019 •
edited
Loading

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=0e5a528fc978a90aa15bbf01f68dd1bf

assert_unwind_safe::<HashMap<(), UnsafeCell<()>>>();

Successfully compiles on stable 1.35, fails on beta/pre 1.36.
@jonas-schievink jonas-schievink added C-bug Category: This is a bug. I-nominated regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-collections Area: std::collections. labels Jul 2, 2019
@CAD97
Copy link
Contributor Author

CAD97 commented Jul 2, 2019

First reported to FireFox ESR and shared on irlo here: https://internals.rust-lang.org/t/rust-1-36-0-pre-release-testing/10490/2?u=cad97

@SimonSapin
Copy link
Contributor

rust/src/libstd/panic.rs

Lines 209 to 212 in ef064d2

#[unstable(feature = "ptr_internals", issue = "0")]
impl<T: UnwindSafe + ?Sized> UnwindSafe for Unique<T> {}
#[stable(feature = "nonnull", since = "1.25.0")]
impl<T: RefUnwindSafe + ?Sized> UnwindSafe for NonNull<T> {}

The UnwindSafe impl for Unique<T> requires T: UnwindSafe, but the one for NonZero<T> requires T: RefUnwindSafe.

@SimonSapin SimonSapin mentioned this issue Jul 2, 2019
Merged
@SimonSapin
Copy link
Contributor

#62304 is a possible fix.

SimonSapin added a commit to SimonSapin/rust that referenced this issue Jul 2, 2019
@SimonSapin
HashMap is UnwindSafe
7454b29 
Fixes rust-lang#62301, a regression in 1.36.0 which was caused by hashbrown using `NonZero<T>` where the older hashmap used `Unique<T>`.
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this issue Jul 2, 2019
@SimonSapin @Mark-Simulacrum
HashMap is UnwindSafe
3e9fc8c 
Fixes rust-lang#62301, a regression in 1.36.0 which was caused by hashbrown using `NonZero<T>` where the older hashmap used `Unique<T>`.
bob-beck pushed a commit to openbsd/ports that referenced this issue Jul 2, 2019
@landryb
Fix build with upcoming rust 1.36.
baf80b4 
found by semarie@ in
https://reviews.freebsd.org/D20810#change-K68aYoUXfAu1, regression in
rust itself tracked in rust-lang/rust#62301

Builds fine with rust 1.35.
bob-beck pushed a commit to openbsd/ports that referenced this issue Jul 2, 2019
@landryb
Fix build with upcoming rust 1.36.
266911a 
found by semarie@ in
https://reviews.freebsd.org/D20810#change-K68aYoUXfAu1, regression in
rust itself tracked in rust-lang/rust#62301

Builds fine with rust 1.35.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 3, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62304 - SimonSapin:safe, r=eddyb
5a507d8 
HashMap is UnwindSafe

Fixes rust-lang#62301, a regression in 1.36.0-pre which was caused by hashbrown using `NonZero<T>` where the older hashmap used `Unique<T>`.
Mark-Simulacrum pushed a commit to Mark-Simulacrum/rust that referenced this issue Jul 3, 2019
@SimonSapin @Mark-Simulacrum
HashMap is UnwindSafe
421160e 
Fixes rust-lang#62301, a regression in 1.36.0 which was caused by hashbrown using `NonZero<T>` where the older hashmap used `Unique<T>`.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jul 3, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#62304 - SimonSapin:safe, r=eddyb
a0fcf5e 
HashMap is UnwindSafe

Fixes rust-lang#62301, a regression in 1.36.0-pre which was caused by hashbrown using `NonZero<T>` where the older hashmap used `Unique<T>`.
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Dec 2, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-collections Area: std::collections. C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

HashMap is UnwindSafe SimonSapin/rust
3 participants
@SimonSapin @jonas-schievink @CAD97