Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libstd requires explicit version of rand crate #62308

Closed
jasonbking opened this issue Jul 2, 2019 · 3 comments
Closed

libstd requires explicit version of rand crate #62308

jasonbking opened this issue Jul 2, 2019 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@jasonbking
Copy link
Contributor

Most everything else in the rustc repo that needs the rand crate is specifying "0.6" for the version, while libstd has "0.6.1" in its Cargo.toml. Unfortunately, this prevented rust from building on illumos systems without manually patching the rand crate (and is a blocker for #55553) in ~/.cargo/.... (without patching, anything using the rand functions will crash with an illegal system call error). The rand crate itself was fixed in Feb, but the libstd dependency on 0.6.1 prevents any fixed version from being used.

It seems likely there must have been a reason to not rely on semver like all the other components, but it's not obvious what it was/if it's still relevant, so it's not clear if merely updating libstd's Cargo.toml to "0.6" is sufficient, or if something more is required.

@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jul 2, 2019
@nagisa
Copy link
Member

nagisa commented Jul 2, 2019

Feel free to send in a PR which changes the version from 0.6.1 to ^0.6.1.

@mati865
Copy link
Contributor

mati865 commented Jul 3, 2019

0.6.1 and ^0.6.1 are exactly the same.
Explicit version would be =0.6.1

What you need to do is upgrading rand in Cargo.lock.

@Mark-Simulacrum
Copy link
Member

I'm closing this as it's either outdated by this point or should likely be resolved with a concrete implementation via PR, we're generally happy to bump dependency versions as needed for work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants