Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for debug_map_key_value #62482

Closed
3 tasks done
KodrAus opened this issue Jul 7, 2019 · 2 comments
Closed
3 tasks done

Tracking issue for debug_map_key_value #62482

KodrAus opened this issue Jul 7, 2019 · 2 comments
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. B-RFC-implemented Blocker: Approved by a merged RFC and implemented but not stabilized. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Jul 7, 2019 •
edited by crlf0710
Loading

This is a tracking issue for debug_map_key_value (rust-lang/rfcs#2696)

Steps:

Unresolved questions:
@KodrAus KodrAus added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. labels Jul 7, 2019
@KodrAus
Copy link
Contributor Author

KodrAus commented Jul 11, 2019

So I’m using this feature to provide an adapter between serde::Serialize and fmt::Debug that naturally preserves formatting flags and stays aligned with any changes to std::fmt.

@KodrAus KodrAus mentioned this issue Jan 14, 2020
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jan 28, 2020
@JohnTitor
Rollup merge of rust-lang#68200 - KodrAus:stabilize/debug_map_key_val…
5c42ffe 
…ue, r=alexcrichton

Stabilize the debug_map_key_value feature

RFC: rust-lang/rfcs#2696
Tracking issue: rust-lang#62482

Stabilizes the `debug_map_key_value` feature, which covers:

```rust
impl<'a, 'b> DebugMap<'a, 'b> {
    pub fn key(&mut self, key: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {}
    pub fn value(&mut self, value: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {}
}
```

These methods are small and self-contained, and are used as the basis for the existing `DebugMap::entry` method, so have been used in the wild for the last 6 months or so.
@crlf0710 crlf0710 added the B-RFC-implemented Blocker: Approved by a merged RFC and implemented but not stabilized. label Jul 22, 2020
@crlf0710
Copy link
Member

Already implemented and stablized. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-RFC-approved Blocker: Approved by a merged RFC but not yet implemented. B-RFC-implemented Blocker: Approved by a merged RFC and implemented but not stabilized. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crlf0710 @KodrAus