Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back suggestion for splitting <- in a comparison #62632

Closed
varkor opened this issue Jul 12, 2019 · 5 comments · Fixed by #63475
Closed

Bring back suggestion for splitting <- in a comparison #62632

varkor opened this issue Jul 12, 2019 · 5 comments · Fixed by #63475
Assignees
@agnxy
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@varkor
Copy link
Member

varkor commented Jul 12, 2019 •
edited by rustbot
Loading 

fn main() {
    if x<-1 {
    }
}

produces:

error: expected `{`, found `<-`

It would be nice if it produced a suggestion to split it up:

if x < -1 {

(This used to happen, but was broken in a previous change.)
@varkor varkor added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints labels Jul 12, 2019
@varkor varkor mentioned this issue Jul 12, 2019
Merged
@agnxy
Copy link
Contributor

agnxy commented Jul 13, 2019 •
edited
Loading

Hi @varkor I'd like to try this one. Just found the removed suggestion.

@agnxy
Copy link
Contributor

agnxy commented Jul 13, 2019

@rustbot claim

@JohnTitor

This comment has been minimized.

Sign in to view
@JohnTitor JohnTitor mentioned this issue Jul 13, 2019
Closed
@jonas-schievink jonas-schievink added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 14, 2019
@iluuu1994
Copy link
Contributor

@agnxy It doesn't look like you're still working on this. Is it ok if I take over?

@iluuu1994 iluuu1994 mentioned this issue Aug 11, 2019
Merged
iluuu1994 added a commit to iluuu1994/rust that referenced this issue Aug 12, 2019
@iluuu1994
Bring back suggestion for splitting <- into < -
91af5c2 
Closes rust-lang#62632
Centril added a commit to Centril/rust that referenced this issue Aug 12, 2019
@Centril
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
b503f8e 
Bring back suggestion for splitting `<-` into `< -`

Closes rust-lang#62632
@agnxy
Copy link
Contributor

agnxy commented Aug 12, 2019

@iluuu1994 Sure. Thanks for your help.

Centril added a commit to Centril/rust that referenced this issue Aug 13, 2019
@Centril
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
86ed4ce 
Bring back suggestion for splitting `<-` into `< -`

Closes rust-lang#62632
Centril added a commit to Centril/rust that referenced this issue Aug 13, 2019
@Centril
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
87ec7b4 
Bring back suggestion for splitting `<-` into `< -`

Closes rust-lang#62632
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Aug 14, 2019
@Mark-Simulacrum
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
2781889 
Bring back suggestion for splitting `<-` into `< -`

Closes rust-lang#62632
Centril added a commit to Centril/rust that referenced this issue Aug 14, 2019
@Centril
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
69848fe 
Bring back suggestion for splitting `<-` into `< -`

Closes rust-lang#62632
Centril added a commit to Centril/rust that referenced this issue Aug 14, 2019
@Centril
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
c824839 
Bring back suggestion for splitting `<-` into `< -`

Closes rust-lang#62632
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agnxy agnxy

Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bring back suggestion for splitting <- into < - iluuu1994/rust
5 participants
@agnxy @iluuu1994 @jonas-schievink @varkor @JohnTitor