Fix test style in unused parentheses lint test

[bravomikekilo]

Update test file to use #![deny(unused_parens)] + //~ ERROR annotations instead of pretty-json (see https://rust-lang.github.io/rustc-guide/tests/adding.html)

The files need to update are:

• test/lint/unused_parens_json_suggestions.rs
• test/lint/used_parens_remove_json_suggestion.rs

This issue has been assigned to @polyedre via this comment.

[JohnTitor]

is the correct file name use_suggestion_json.rs, not used_parens_remove_json_suggestion.rs?

And what about this comment?

rust/src/test/ui/lint/unused_parens_json_suggestion.rs

Lines 4 to 8 in 2c13edc

	// The output for humans should just highlight the whole span without showing
	// the suggested replacement, but we also want to test that suggested
	// replacement only removes one set of parentheses, rather than naïvely
	// stripping away any starting or ending parenthesis characters—hence this
	// test of the JSON error format.

[polyedre]

Is the problem fixed ? If not, I would like to work on it !

[JohnTitor]

@polyedre WIP PR has been closed due to inactivity so you can work on this.

[polyedre]

@JohnTitor I would like to be assigned to this issue. Am I supposed to do a new pull request ?

[rustbot]

Error: Parsing assign command in comment failed: ...tbot claim|error: expected end of command at >| @polyedre...

Please let @rust-lang/release know if you're having trouble with this bot.

[rustbot]

Error: Parsing assign command in comment failed: ...tbot claim|error: expected end of command at >| @polyedre...

Please let @rust-lang/release know if you're having trouble with this bot.

[JohnTitor]

Hmm, it's odd, anyway, you can assign the issue to yourself by comment @rustbot claim
Ah, I mistaken the command, the collect one is assign, sorry.

[polyedre]

@rustbot claim

[polyedre]

If I understood well the problem:

1. I must replace all the pretty-json by just json, even if this comment exist ?
2. Because the output changes, I should modify the .stderr version
3. I must change warning with deny in #![warn(unused_parens)], and as this line should raise an error we add //~ ERROR
4. But why add //~ERROR in the *.fixed version ?