Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::env::var and std::env::var_os do not document panic on key containing null byte #63456

Closed
lopopolo opened this issue Aug 11, 2019 · 0 comments · Fixed by #63461
Closed

std::env::var and std::env::var_os do not document panic on key containing null byte #63456

lopopolo opened this issue Aug 11, 2019 · 0 comments · Fixed by #63461
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools

Comments

@lopopolo
Copy link
Contributor

env::remove_var and env::set_var document that they panic when the key contains a null byte, but env::var and env::var_os do not document this behavior.

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e43934f459b10424f374f20db846f092
@estebank estebank added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Aug 11, 2019
@tommilligan tommilligan mentioned this issue Aug 11, 2019
Merged
Centril added a commit to Centril/rust that referenced this issue Aug 12, 2019
@Centril
Rollup merge of rust-lang#63461 - tommilligan:doc-var-panic, r=joshtr…
61e7fbd 
…iplett

docs: add stdlib env::var(_os) panic

Closes rust-lang#63456
Centril added a commit to Centril/rust that referenced this issue Aug 12, 2019
@Centril
Rollup merge of rust-lang#63461 - tommilligan:doc-var-panic, r=joshtr…
4d27aac 
…iplett

docs: add stdlib env::var(_os) panic

Closes rust-lang#63456
@lopopolo lopopolo mentioned this issue Aug 15, 2021
Merged
@Amanieu Amanieu mentioned this issue Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add stdlib env::var(_os) panic tommilligan/rust
2 participants
@lopopolo @estebank